fix typos present in '@theia/core' #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin8502
changed the title
|
Still figuring out how merges work. Reset fork to point to upstream, then created a branch from fork with changes for this issue (previously i was just pushing to master). |
vince-fugnitto
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
The changes look good to me! 👍
Thank you for your contribution, I understand that working off forks may be confusing at first but there should be some good articles about successfully contributing to open-source using forks :)
For example, the following article describes the usual steps when working in open-source with forks in an easy to convey matter.
|
The branch does look to be in a weird state however as it cannot be rebased safely: 
Perhaps follow the general guide described in the article I mentioned. |
|
Looking into it. |
vince-fugnitto
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6899
What it does
Review checklist
Reminder for reviewers